New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibGfx+LibCompress: Add a GIF encoder #24191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a nice start!
Maybe worth having a test that tests that a black-and-white bitmap roundtrips ok through gif writer followed by gif loader?
I added a roundtrip test for webp to #24212. Adding a gif roundtrip test for that should be maybe 8 lines of code. (It would be 4 if you didn't have to convert the built-in test bitmaps to black-and-white.) |
(Maybe you forgot to |
(Nah I'm fighting the roundtrip test I just added 😅) |
It should be all good now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One large round of feedback, but I think that's all that we need.
This is more idiomatic for LibCompress' decoders.
This version is really barebone as it does not support colors (only black and white) or animated images.
This version is really barebone as it does not support colors (only
black and white) or animated images.