Kernel: Prepare and clean before the big PCI subsystem new design #24152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
spholz
reviewed
Apr 28, 2024
supercomputer7
force-pushed
the
prepare-to-pci-refactor
branch
2 times, most recently
from
5aa92ae
to
8cda2c1
Compare
|
I had to remove supercomputer7@0bfc7b0 from this PR, as |
supercomputer7
force-pushed
the
prepare-to-pci-refactor
branch
2 times, most recently
from
a53c1c2
to
aa0afdc
Compare
ADKaster
added
the
⚠️ pr-has-conflicts
We never used these virtual methods outside their own implementation, so let's stop pretending that we should be able to utilize this for unknown purpose.
We can just do the initialization sequence in the constructor.
Prepare to remove biglock on PCI::Access in a future commit, so we can ensure we only lock a spinlock on a precise PCI HostController if needed instead of the entire subsystem.
GenericGraphicsAdapter is mouthful. Also, the idea is to move towards a more advanced subsystem that handles GPUs, not merely graphics adapters.
This code is actually for the old PIIX4 PCI host bridge, which requires to use legacy x86 IO instructions.
supercomputer7
force-pushed
the
prepare-to-pci-refactor
branch
from
aa0afdc
to
388100c
Compare
supercomputer7
removed
the
⚠️ pr-has-conflicts
This file will be removed in a future commit, so let's get rid of what we can right now.
ADKaster
approved these changes
May 14, 2024
supercomputer7
force-pushed
the
prepare-to-pci-refactor
branch
from
388100c
to
8e25696
Compare
ADKaster
added
✅ pr-maintainer-approved-but-awaiting-ci
github-actions
bot
added
👀 pr-needs-review
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits are taken from #23448.
It mostly boils down to cleaning lots of mess and prepare before we could remove the old design and put the new one.