Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibWeb: More animation fixes #23486

Merged
merged 6 commits into from Mar 6, 2024
Merged

LibWeb: More animation fixes #23486

merged 6 commits into from Mar 6, 2024

Commits on Mar 6, 2024

  1. LibWeb: Prevent transform interpolations from failing 

    Style computation should never fail. Instead, we just ignore the
transformation that led to the invalid matrix.
    @mattco98
    mattco98 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    ca8339d View commit details
    Browse the repository at this point in the history

  2. AK: Add HashMap::ensure_capacity

    @mattco98
    mattco98 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    cdac0a9 View commit details
    Browse the repository at this point in the history

  3. LibWeb: Remove unnecessary ErrorOr<> from StyleComputer 

    All of this error propogation came from a single call to
HashMap::try_ensure_capacity! As part of the ongoing effort to ignore
small allocation failures, lets just assert this works. This has the
nice side-effect of propogating out to a few other classes.
    @mattco98
    mattco98 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    2cda21f View commit details
    Browse the repository at this point in the history

  4. LibWeb: Do not assert the type of transformation style values 

    In this case, the StyleValue may be "unresolved", however let's just
avoid the assert altogether and treat all non-transform values as
"none".
    @mattco98
    mattco98 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    5946fa6 View commit details
    Browse the repository at this point in the history

  5. LibWeb: Consider fill state before calling Animation::play() 

    Animation::play_state() does not consider the fill state, and thus will
not return "Playing" for a fill-forward animation in the after phase.
It is still valid for paused, as pausing is not affected by the fill
mode.
    @mattco98
    mattco98 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    328db54 View commit details
    Browse the repository at this point in the history

  6. LibWeb: Don't render elements with invalid interpolated transform values

    @mattco98
    mattco98 committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    68f1d2c View commit details
    Browse the repository at this point in the history