Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ladybird: cannot scroll on warpdesign.fr #23599

Closed
warpdesign opened this issue Mar 15, 2024 · 1 comment · Fixed by #24008
Closed

Ladybird: cannot scroll on warpdesign.fr #23599

warpdesign opened this issue Mar 15, 2024 · 1 comment · Fixed by #24008

Comments

@warpdesign
Copy link
Contributor

Scrolling doesn't work on warpdesign.fr: the scrollbar is visible on the right but trackpad gestures and drag/dropping the scrollbar does nothing.

Also, there are endless Can't keep up... messages in the terminal:

logs-flood.mov
@DanShaders
Copy link
Contributor

Hmm, this "Can't keep up" spam might be a separate issue. Can you figure out which timer causes it?

Since I don't think there is a time-travel debugger for MacOS, it probably won't be as straightforward as I wished it would be but you can do something like this:

  1. Connect to WebContent with gdb (or whichever debugger there is on macos)
  2. Break here on an offending timer
  3. Figure out what is strong_owner
  4. Break here when reciever is the same as the strong_owner from the previous step
  5. Step into a few times and at some point you will fall through to the handler of that timer and then it should be obvious to understand the purpose of the timer.

kalenikaliaksandr added a commit to kalenikaliaksandr/serenity that referenced this issue Apr 18, 2024
@kalenikaliaksandr
LibWeb: Ignore mousewheel events in ViewportPaintable
02512f1 
That allow EventHandler process wheel event on corresponding navigable.
For top-level navigable that means IPC call to let chrome know about
scrollbar position update.

Fixes SerenityOS#23599
Fixes SerenityOS#23493
Fixes SerenityOS#23966
@kalenikaliaksandr kalenikaliaksandr mentioned this issue Apr 18, 2024
Merged
awesomekling pushed a commit that referenced this issue Apr 18, 2024
@kalenikaliaksandr @awesomekling
LibWeb: Ignore mousewheel events in ViewportPaintable
bad86ca 
That allow EventHandler process wheel event on corresponding navigable.
For top-level navigable that means IPC call to let chrome know about
scrollbar position update.

Fixes #23599
Fixes #23493
Fixes #23966
alimpfard pushed a commit to alimpfard/serenity that referenced this issue Apr 22, 2024
@kalenikaliaksandr @alimpfard
LibWeb: Ignore mousewheel events in ViewportPaintable
e9ba462 
That allow EventHandler process wheel event on corresponding navigable.
For top-level navigable that means IPC call to let chrome know about
scrollbar position update.

Fixes SerenityOS#23599
Fixes SerenityOS#23493
Fixes SerenityOS#23966
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LibWeb: Ignore mousewheel events in ViewportPaintable kalenikaliaksandr/serenity
2 participants
@warpdesign @DanShaders