LibWeb: Ignore mousewheel events in ViewportPaintable

That allow EventHandler process wheel event on corresponding navigable. For top-level navigable that means IPC call to let chrome know about scrollbar position update. Fixes #23599 Fixes #23493 Fixes #23966
SerenityOS · Apr 18, 2024 · bad86ca · bad86ca
1 parent d530584
commit bad86ca
Show file tree

Hide file tree

Showing 4 changed files with 62 additions and 0 deletions.
diff --git a/Tests/LibWeb/Text/expected/scroll-window-using-wheel-event.txt b/Tests/LibWeb/Text/expected/scroll-window-using-wheel-event.txt
@@ -0,0 +1 @@
+              new scrollY: 100
diff --git a/Tests/LibWeb/Text/input/scroll-window-using-wheel-event.html b/Tests/LibWeb/Text/input/scroll-window-using-wheel-event.html
@@ -0,0 +1,54 @@
+<!DOCTYPE html>
+<style>
+    body {
+        overflow: scroll;
+    }
+
+    .box {
+        height: 300px;
+        width: 200px;
+    }
+
+    .red {
+        background-color: red;
+    }
+
+    .green {
+        background-color: green;
+    }
+
+    .cyan {
+        background-color: cyan;
+    }
+
+    .pink {
+        background-color: pink;
+    }
+
+    .blue {
+        background-color: blue;
+    }
+</style>
+<div class="container">
+    <div class="box red"></div>
+    <div class="box green"></div>
+    <div class="box blue"></div>
+    <div class="box pink"></div>
+    <div class="box cyan"></div>
+    <div class="box red"></div>
+    <div class="box green"></div>
+    <div class="box blue"></div>
+    <div class="box pink"></div>
+    <div class="box cyan"></div>
+</div>
+<script src="include.js"></script>
+<script>
+    asyncTest(done => {
+        const container = document.querySelector(".container");
+        window.onscroll = () => {
+            println(`new scrollY: ${window.scrollY}`);
+            done();
+        };
+        internals.wheel(50, 50, 0, 100);
+    });
+</script>
diff --git a/Userland/Libraries/LibWeb/Painting/ViewportPaintable.cpp b/Userland/Libraries/LibWeb/Painting/ViewportPaintable.cpp
@@ -515,6 +515,11 @@ void ViewportPaintable::recompute_selection_states()
     }
 }
 
+bool ViewportPaintable::handle_mousewheel(Badge<EventHandler>, CSSPixelPoint, unsigned, unsigned, int, int)
+{
+    return false;
+}
+
 void ViewportPaintable::visit_edges(Visitor& visitor)
 {
     Base::visit_edges(visitor);

diff --git a/Userland/Libraries/LibWeb/Painting/ViewportPaintable.h b/Userland/Libraries/LibWeb/Painting/ViewportPaintable.h
@@ -34,6 +34,8 @@ class ViewportPaintable final : public PaintableWithLines {
     JS::GCPtr<Selection::Selection> selection() const;
     void recompute_selection_states();
 
+    bool handle_mousewheel(Badge<EventHandler>, CSSPixelPoint, unsigned, unsigned, int wheel_delta_x, int wheel_delta_y) override;
+
 private:
     void build_stacking_context_tree();