Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ladybird: scrolling not working on https://html5test.opensuse.org/ #23493

Closed
warpdesign opened this issue Mar 6, 2024 · 0 comments · Fixed by #24008
Closed

Ladybird: scrolling not working on https://html5test.opensuse.org/ #23493

warpdesign opened this issue Mar 6, 2024 · 0 comments · Fixed by #24008

Comments

@warpdesign
Copy link
Contributor

Scrolling does not work anymore in https://html5test.opensuse.org/

Using git bisect I was able to trace the problem to this commit.

That's on macOS with the appkit chrome.
kalenikaliaksandr added a commit to kalenikaliaksandr/serenity that referenced this issue Apr 18, 2024
@kalenikaliaksandr
LibWeb: Ignore mousewheel events in ViewportPaintable
02512f1 
That allow EventHandler process wheel event on corresponding navigable.
For top-level navigable that means IPC call to let chrome know about
scrollbar position update.

Fixes SerenityOS#23599
Fixes SerenityOS#23493
Fixes SerenityOS#23966
@kalenikaliaksandr kalenikaliaksandr mentioned this issue Apr 18, 2024
Merged
awesomekling pushed a commit that referenced this issue Apr 18, 2024
@kalenikaliaksandr @awesomekling
LibWeb: Ignore mousewheel events in ViewportPaintable
bad86ca 
That allow EventHandler process wheel event on corresponding navigable.
For top-level navigable that means IPC call to let chrome know about
scrollbar position update.

Fixes #23599
Fixes #23493
Fixes #23966
alimpfard pushed a commit to alimpfard/serenity that referenced this issue Apr 22, 2024
@kalenikaliaksandr @alimpfard
LibWeb: Ignore mousewheel events in ViewportPaintable
e9ba462 
That allow EventHandler process wheel event on corresponding navigable.
For top-level navigable that means IPC call to let chrome know about
scrollbar position update.

Fixes SerenityOS#23599
Fixes SerenityOS#23493
Fixes SerenityOS#23966
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LibWeb: Ignore mousewheel events in ViewportPaintable kalenikaliaksandr/serenity
1 participant
@warpdesign