Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSv3: get the "nested" flag right #452

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OPSv3: get the "nested" flag right #452

wants to merge 1 commit into from

Commits on Jun 16, 2023

  1. OPSv3: get the "nested" flag right 

    "nested" semantically probably is meant to mean "another OPS packet follows".
But the byte on the wire is defined as 0 means another OPS packet follows.

Furthermore, the flags are set in the wrong way: before this commit, the
code produced a series of OPS packets where the first packet had a different
value for the flag than all subsequent ones.  What we want is where all the
flags *except* the last OPS packet (corresponding to the *first* Sig packet)
are 0.

See https://gitlab.com/sequoia-pgp/openpgp-interoperability-test-suite/-/issues/84
    @dkg
    dkg committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    773f39b View commit details
    Browse the repository at this point in the history