Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Dont crash in cli context #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BUGFIX: Dont crash in cli context #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion Classes/Service/WorkspaceActivityService.php
View file
Open in desktop
Expand Up @@ -78,7 +78,12 @@ public function nodeDiscarded(NodeInterface $node): void

public function shutdownObject(): void
{
$currentUser = $this->securityContext->getAccount()->getAccountIdentifier();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not skip the update of the workspace in general but instead skip updating the last editor and still update the last edited date time.

$account = $this->securityContext->getAccount();
if (!$account) {
// probably in cli context
return;
}
$currentUser = $account->getAccountIdentifier();

foreach ($this->updatedWorkspaces as $updatedWorkspace) {
$workspaceDetails = $this->workspaceDetailsRepository->findOneByWorkspace($updatedWorkspace);
Expand Down