BUGFIX: directly register event-listener for ctrl-k #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this is a browser-hotkey on Windows and Linux, we need to prevent the default-handling of the event, but the neos-ui doesn't provide a way to configure hotkeys like that.
Sebobo
requested changes
Mar 15, 2023
Sebobo
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the registration of the ctrl+k hotkey for Neos completely and added the event-handler directly analogous to the module-ui.
Sadly it doesn't seem possible to prevent the default-behavior with the neos-ui hotkey-handling, as neither the event is passed to the handler nor a return value could be set from the handler:
https://github.com/neos/neos-ui/blob/a0683ed157699042aa269ea0819977efafb5be46/packages/neos-ui-sagas/src/UI/Hotkeys/index.js#L14-L16
This PR does not contain a build to avoid conflicts, but I can add it, if preferred.