BUGFIX: Setting command as favourite didn’t update it’s state properly

Sebobo · Mar 15, 2023 · 61c0d77 · 61c0d77
1 parent 3928c06
commit 61c0d77
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/packages/commandbar/src/state/commandBarReducer.ts b/packages/commandbar/src/state/commandBarReducer.ts
@@ -145,7 +145,7 @@ function runAction(action: ACTION, nextState: CommandBarState, event: CommandBar
         case ACTION.ADD_FAVOURITE:
             assert(event.type === TRANSITION.ADD_FAVOURITE);
             if (!nextState.favouriteCommands.includes(event.commandId)) {
-                nextState.favouriteCommands.push(event.commandId);
+                nextState.favouriteCommands = [...nextState.favouriteCommands, event.commandId];
             }
             break;
         case ACTION.REMOVE_FAVOURITE: