Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): image editor #202

Draft
wants to merge 6 commits into
base: feature/website
Choose a base branch
from

Conversation

lennartkloock
Copy link
Member

@lennartkloock lennartkloock commented Jan 25, 2024

Proposed changes

This implements an image editor you can use to crop and scale images before uploading.

Types of changes

What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Closes #187

Depends on #197

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (09f345e) 45.48% compared to head (abf1024) 45.48%.
Report is 1 commits behind head on feature/website.

Additional details and impacted files
@@               Coverage Diff                @@
##           feature/website     #202   +/-   ##
================================================
  Coverage            45.48%   45.48%           
================================================
  Files                  489      489           
  Lines                32133    32133           
================================================
  Hits                 14617    14617           
  Misses               17516    17516           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(platform/website): image cropping tool for image upload
1 participant