Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VUU-27 remotePersistenceManager implementation #74

Merged
merged 18 commits into from
Oct 25, 2023
Merged

VUU-27 remotePersistenceManager implementation #74

merged 18 commits into from
Oct 25, 2023

Conversation

vferraro-scottlogic
Copy link

@vferraro-scottlogic vferraro-scottlogic commented Oct 16, 2023 •
edited

  • verify against server

Changes

  • RemoteLayoutPersistenceManager implementation
  • rename "date" to created in LayoutMetadata type
  • change return type for createLayout in LayoutPersistenceManager to Promise
  • edit LocalLayoutPersistenceManager.createLayout to return Metadata
  • add unit tests for RemoteLayoutPersistenceManager
  • change unit tests for LocalLayoutPersistenceManager
  • add catching layer to LayoutManagerProvider()
  • introduce environment variable for switching between local and remote layout manager

@vferraro-scottlogic vferraro-scottlogic self-assigned this Oct 18, 2023
@vferraro-scottlogic vferraro-scottlogic changed the title VUU-27 remotePersistenceManager implementation WIP-VUU-27 remotePersistenceManager implementation Oct 18, 2023
@vferraro-scottlogic vferraro-scottlogic changed the title WIP-VUU-27 remotePersistenceManager implementation VUU-27 remotePersistenceManager implementation Oct 18, 2023
@cfisher-scottlogic cfisher-scottlogic linked an issue Oct 19, 2023 that may be closed by this pull request
Add remote layout management to UI #27
Closed
cfisher-scottlogic
cfisher-scottlogic approved these changes Oct 20, 2023
View reviewed changes
Copy link

@cfisher-scottlogic cfisher-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only a couple minor points.

.semgrepignore Show resolved Hide resolved
vuu-ui/packages/vuu-layout/src/layout-persistence/RemoteLayoutPersistenceManager.ts Outdated Show resolved Hide resolved
vuu-ui/packages/vuu-layout/src/layout-persistence/RemoteLayoutPersistenceManager.ts Show resolved Hide resolved
vuu-ui/packages/vuu-layout/src/layout-persistence/RemoteLayoutPersistenceManager.ts Outdated Show resolved Hide resolved
vuu-ui/packages/vuu-layout/src/layout-persistence/RemoteLayoutPersistenceManager.ts Outdated Show resolved Hide resolved
vuu-ui/packages/vuu-layout/src/layout-persistence/RemoteLayoutPersistenceManager.ts Show resolved Hide resolved
vuu-ui/packages/vuu-layout/src/layout-persistence/RemoteLayoutPersistenceManager.ts Outdated Show resolved Hide resolved
vuu-ui/packages/vuu-shell/src/layout-management/useLayoutManager.tsx Show resolved Hide resolved
vuu-ui/showcase/src/examples/Apps/NewTheme.examples.tsx Outdated Show resolved Hide resolved
pling-scottlogic
pling-scottlogic requested changes Oct 20, 2023
View reviewed changes
vuu-ui/packages/vuu-layout/src/layout-persistence/LayoutPersistenceManager.ts Outdated Show resolved Hide resolved
vuu-ui/packages/vuu-layout/src/layout-persistence/RemoteLayoutPersistenceManager.ts Outdated Show resolved Hide resolved
vuu-ui/packages/vuu-layout/src/layout-persistence/RemoteLayoutPersistenceManager.ts Show resolved Hide resolved
vuu-ui/packages/vuu-layout/src/layout-persistence/RemoteLayoutPersistenceManager.ts Show resolved Hide resolved
vuu-ui/packages/vuu-layout/src/layout-persistence/RemoteLayoutPersistenceManager.ts Show resolved Hide resolved
vuu-ui/packages/vuu-layout/src/layout-persistence/RemoteLayoutPersistenceManager.ts Show resolved Hide resolved
vuu-ui/packages/vuu-layout/test/layout-persistence/LocalLayoutPersistenceManager.test.ts Show resolved Hide resolved
vuu-ui/packages/vuu-layout/test/layout-persistence/RemoteLayoutPersistenceManager.test.ts Outdated Show resolved Hide resolved
vuu-ui/packages/vuu-layout/test/layout-persistence/RemoteLayoutPersistenceManager.test.ts Outdated Show resolved Hide resolved
vuu-ui/packages/vuu-layout/test/layout-persistence/RemoteLayoutPersistenceManager.test.ts Outdated Show resolved Hide resolved
vferraro-scottlogic
vferraro-scottlogic commented Oct 25, 2023
View reviewed changes
vuu-ui/packages/vuu-layout/src/layout-persistence/RemoteLayoutPersistenceManager.ts
method: "POST",
body: JSON.stringify({
metadata,
definition: JSON.stringify(layout),
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do need this JSON.stringify() until we change the definition type #81

@vferraro-scottlogic vferraro-scottlogic merged commit 679155b into main Oct 25, 2023
7 checks passed
@cfisher-scottlogic cfisher-scottlogic deleted the VUU-27-remote-layout-management branch November 1, 2023 11:11
@pling-scottlogic pling-scottlogic mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfisher-scottlogic cfisher-scottlogic cfisher-scottlogic approved these changes

@pling-scottlogic pling-scottlogic pling-scottlogic approved these changes

Assignees

@vferraro-scottlogic vferraro-scottlogic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add remote layout management to UI
3 participants
@vferraro-scottlogic @pling-scottlogic @cfisher-scottlogic