Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Pin pytest-mpl less than 0.17 #2367

Closed
wants to merge 1 commit into from

Conversation

greglucas
Copy link
Contributor

@greglucas greglucas commented Apr 10, 2024

v0.17 of pytest-mpl might be producing flaky results on CI, so pin it to the old version for now until a new fix comes out.

This is a WIP to see if it is actually the culprit or not. This is just an educated guess based on their release date in February and images failing that don't require external resources.
Possibly related to: matplotlib/pytest-mpl#225

v0.17 of pytest-mpl seems to be producing flaky results on CI, so
pin it to the old version for now until a new fix comes out.
@rcomer
Copy link
Member

rcomer commented Apr 10, 2024

I was just looking at some of the failures from the last commit to main. For some of the gridliner tests we appear to have lost an island! (I think it's Prince Patrick's Island - furthest north on the 120W line).

Baseline:
baseline

Result:
result

@rcomer
Copy link
Member

rcomer commented Apr 13, 2024

Because several of the failures I looked at were due to missing bits of coastline, I had been wondering if this was some kind of local i/o problem within GHA. Now I have a new failure:

E   fiona.errors.DriverError: 'C:\Users\runneradmin\.local\share\cartopy\shapefiles\natural_earth\physical\ne_110m_coastline.shp' not recognized as a supported file format.

https://github.com/rcomer/cartopy/actions/runs/8673960218/job/23785789451#step:9:170

@greglucas
Copy link
Contributor Author

🤔 I wonder if Fiona is causing issues?
1.9.6 was released March 8, which is around when we started seeing the flaky issues. https://github.com/Toblerity/Fiona/releases

@rcomer
Copy link
Member

rcomer commented Apr 13, 2024

🤔 I wonder if Fiona is causing issues? 1.9.6 was released March 8, which is around when we started seeing the flaky issues. https://github.com/Toblerity/Fiona/releases

I should probably have mentioned that I tried this: rcomer@1800e8b

@rcomer
Copy link
Member

rcomer commented Apr 13, 2024

It does seem like there was some kind of change to actions storage space around the end of February, but this is getting way out of my wheelhouse actions/runner#3184

@lgolston lgolston mentioned this pull request Apr 21, 2024
@greglucas
Copy link
Contributor Author

Closing as this doesn't seem to be the problem.

@greglucas greglucas closed this May 26, 2024
@greglucas greglucas deleted the tst-pin-pytest-mpl branch May 26, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants