Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scispark-61 generating the openDap urls #66

Merged
merged 27 commits into from
Jul 4, 2016
Merged

Scispark-61 generating the openDap urls #66

merged 27 commits into from
Jul 4, 2016

Conversation

kwhitehall
Copy link
Member

No description provided.

@kwhitehall
Copy link
Member Author

Still working on this PR.

@chrismattmann
Copy link
Collaborator

LGTM as a start. @kwhitehall

@kwhitehall
Copy link
Member Author

kwhitehall commented Jul 2, 2016

Ok @chrismattmann and @rahulpalamuttam
I think I'm finished with this PR.
To run the unit test, from command line the following is required
SBT_OPTS="-DhdfsURL=hdfs://url_host:port" sbt "test-only org.dia.urlgenerators.OpenDapTRMMURLGeneratorTest"

TODO: is to get the thread / waiting between calls to the openDap server in the SciSparkContext.scala line 106 going.

Finally, this PR addresses issue #61 and #67 (indirectly - the openDap and any url from file will now be read into a rdd of SciTensors)

@chrismattmann
Copy link
Collaborator

LGTM +1 to commit. @kwhitehall @rahulpalamuttam

@kwhitehall
Copy link
Member Author

Ack'ed @chrismattmann. Thanks!

@kwhitehall kwhitehall merged commit b416d53 into master Jul 4, 2016
@kwhitehall kwhitehall deleted the scispark-61 branch July 4, 2016 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants