ModelNode: fix lightNodes and cameraNodes parent #484
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the
ModuleNode
creation, an incorrect parent is set tolightNodes
andcameraNodes
. Without specifying a scope forthis
the LightNode and CameraNode scope is used by default (because ofapply
). As a result, the node's parent is the node itself, leading to a StackOverflow exception when traversing these nodes.