add viewnode to ar-model-viewer sample #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS I wasn't able to test this addition unfortunately. That's because this sample code is already crashing. I wasn't able to see any glaring crash issues that would be helpful, but here are the logs: |
ThomasGorisse
approved these changes
Apr 19, 2024
|
hello, i try use that sample in my project, but i get "black hole", i try build your sample - and same i get black hole https://drive.google.com/file/d/1Dd8VmHjhMH-2BypYYFED9OGxy9_B_Qha/view?usp=drivesdk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ViewNode is in high demand in terms of library functionality, it seems. Putting ViewNode in the sample code
A) shows users how to use this functionality
B) makes it a core part of testing of the library