Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make redis configurable and bump channels version #155

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mldulaney
Copy link

This provides the config option for setting the redis host.

Signed-off-by: Mairi Dulaney <jdulaney@fedoraproject.org>
Signed-off-by: Mairi Dulaney <jdulaney@fedoraproject.org>
@dreinhold
Copy link
Contributor

The bump in channels is causing the CI build to fail :
error message

The conflict is caused by:
    The user requested asgiref==3.3.4
    channels 3.0.5 depends on asgiref<4 and >=3.5.0
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

@mldulaney
Copy link
Author

oh, okay, it worked locally, I'll poke it when I get home.

Signed-off-by: Mairi Dulaney <jdulaney@fedoraproject.org>
@mldulaney
Copy link
Author

aight, that is done.

@dreinhold
Copy link
Contributor

dreinhold commented Jul 31, 2022

Okay cool it does build, did you see my note asking if you could update the settings to make them look for environment variables also, so it would work in docker?

Sorry was waiting for that before merging .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants