Don't close subscriber if channel is recoverable. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkiedys thanks so much for the quick response! I have tested this locally and it does in fact address the issue. We are hoping to push to production later today or tomorrow and I'll be able to confirm at that point. Again, thanks for the great library! |
|
@mkiedys I can confirm it has fixed our issue. We have a brief connection drop every night, and the released version of reactive-rabbit causes our app to discontinue handling messages. This PR enables our app to continue handling messages after the dropped connection. So +1 for merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.