New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add header for reauth purposes #155
Conversation
jesusbv
commented
Apr 19, 2024
•
edited
edited
- When refreshing the credentials server side, add a header to explicitly set the registry cache file
- When refreshing the credentials server side, add a header to explicitly set the cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nitpick on the test, the code looks good to me 👍
I'm missing details about the motivation of the new header field as well as where it's been used or what consumes it. I guess this information is in some other API documentation ? I again reviewed only in terms of code not in terms of functionality as a whole
On the server side we, i.e. people working on the registry as part of RMT project have currently 2 PRs pending, SUSE/rmt#1124 and SUSE/rmt#1128. As commented in 1128 I do not understand the need for it given 1124. Also My understanding based on 1124 in the RMT project is as follows: When the client, docker or podman, come to visit they will send a token. The code in 1124 will check if the Meaning this change is not needed. |
I understood that the behavior on 1124 was correct until
meaning we would need to force a reauth, depending on that comment or, in other words, whether we are OK having the expiration of the access updated by any access of |
Clarified that |