Add registry sidecar support #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Switching to draft, we are still in the scoping phase of the project. |
Set registry FQDN as registry-framework.susecloud.net in SMT Use SMT object to get registry FQDN Update tests
jesusbv
force-pushed
the
add-registry-sidecar-support
branch
from
46f3eba
to
f3cf6c0
Compare
When login with docker/podman, an auths token is written to the config file - Set that config file with the auth token without running login command
bear454
reviewed
Mar 11, 2024
schaefi
reviewed
Mar 12, 2024
| auth_token = base64.b64encode('{username}:{password}'.format( | ||
| username=username, | ||
| password=password | ||
| ).encode()).decode() |
There was a problem hiding this comment.
We carry the username and password information as base64 for obfuscation reasons right ? not for security, right ? Just asking because there is no security with b64encode
There was a problem hiding this comment.
it is not because of security, it is because we have to, docker|podman dont like anything that is not base64
> cat ${XDG_RUNTIME_DIR}/containers/auth.json
{
"auths": {
"registry.suse-local.com:5000": {
"auth": "SCC_foo:password_bar"
}
}
}
> podman login --tls-verify=false
Error: get credentials: 1 error occurred:
* illegal base64 data at input byte 72
> cat ~/.docker/config.json
{
"auths": {
"registry.suse-local.com:5000": {
"auth": "SCC_foo:password_bat"
}
}
}
> docker login registry.suse-local.com:5000
WARNING: Error loading config file: ~/.docker/config.json: illegal base64 data at input byte 3
Username:from the podman doc
[...] Podman creates ${XDG_RUNTIME_DIR}/containers/auth.json (if the file does not exist) and then stores the username and password from STDIN as a base64 encoded string in it
from the docker doc
[...]
If none of these binaries are present, it stores the credentials (i.e. password) in base64 encoding in the config files described above
schaefi
reviewed
Mar 13, 2024
- Add registry sidecar RMT and SUSE registry URLs to podmand and docker config files - Add toml to spec file
- Update tests to reflect the change
jesusbv
force-pushed
the
add-registry-sidecar-support
branch
from
4ab64d5
to
243d380
Compare
jesusbv
force-pushed
the
add-registry-sidecar-support
branch
from
f216223
to
243d380
Compare
- For podman set registry outside the unqualified search registries in order to be able to inform the user when credentials expired and a reauth is needed - For docker do not add registry-<csp>.susecloud.net to the search docker does not suppoert auth search, and the registry will not show free repos - Update tests
- Remove duplication - Add check for Docker - Log if configuration files not found
|
Closing in favor of #157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.