Check if instance has Ipv4 or IPv6 enabled #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using '--force-new --smt-ip ...' options, validate that the instance can use the --smt-ip value in order to save debugging or unnecessary errors
jesusbv
commented
Aug 29, 2023
- Leverage has_ipv6_access - Refactor has_ipv6_access to accomodate IPv4 check
|
once approve, I will squash the commits into one |
rjschwei
requested changes
Oct 31, 2023
- Less knowledge littering - Check request exception for - established connection - timeout - Handle general request exception
- The message is checked if connection failed, use that and remove the if to set the message
rjschwei
requested changes
Nov 20, 2023
We want to check if the IP provided (IPv4 or IPv6) is enabled on the client, so they can actually use that IP |
- Rename method to reflect the correct intend - Check if a request could be made, handle behaviour accordingly
rjschwei
reviewed
Nov 21, 2023
- Check socket connection - Restore has_ipv6_access as it was - Remove __connection_check
rjschwei
requested changes
Apr 29, 2024
- When checking if instance can access IPv6 infra server, make sure the instance can handle IPv6 addresses
rjschwei
requested changes
May 10, 2024
rjschwei
reviewed
May 16, 2024
rjschwei
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using '--force-new --smt-ip ...' options,
validate that the instance can use the --smt-ip value in order to save debugging or unnecessary errors