Skip to content

Commit

Permalink
Add tests for config
Browse files Browse the repository at this point in the history
  • Loading branch information
jesusbv committed Apr 23, 2024
1 parent 1046b56 commit 6df7b70
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 1 deletion.
1 change: 0 additions & 1 deletion lib/cloudregister/registerutils.py
Expand Up @@ -524,7 +524,6 @@ def set_registry_config(registry_fqdn, username, password):
os.path.expanduser('~'), DOCKER_REGISTRY_CREDENTIALS_PATH
),
os.path.join(os.sep, 'root', DOCKER_REGISTRY_CREDENTIALS_PATH),
os.getenv('XDG_RUNTIME_DIR') # podman path
]
for cfg_path in registry_credentials_paths:
set_registry_credentials(registry_fqdn, username, password, cfg_path)
Expand Down
26 changes: 26 additions & 0 deletions tests/test_registerutils.py
Expand Up @@ -3149,6 +3149,32 @@ def open_file(filename, mode):
]


@patch('cloudregister.registerutils.os.path.expanduser')
@patch('cloudregister.registerutils.set_registry_order_search')
@patch('cloudregister.registerutils.set_registry_credentials')
def test_set_registry_config(
mock_set_registry_cred, mock_set_registry_search, mock_os_path_expanduser
):
mock_os_path_expanduser.return_value = 'regular_path'
utils.set_registry_config('registry_fqdn', 'username', 'pass')
assert mock_set_registry_cred.call_args_list == [
call(
'registry_fqdn',
'username',
'pass',
'regular_path/.docker/config.json'
),
call(
'registry_fqdn',
'username',
'pass',
'/root/.docker/config.json'
)

]
mock_set_registry_search.assert_called_once_with('registry_fqdn')


@patch('cloudregister.registerutils._set_registry_order_search_docker')
@patch('cloudregister.registerutils._set_registry_order_search_podman')
def test_set_registry_order_search(mock_podman_order, mock_docker_order):
Expand Down

0 comments on commit 6df7b70

Please sign in to comment.