Fixing homepage broken image #2363

amankumarrr · 2024-03-25T02:47:55Z

Affected Route: /
Fixed : #2362

Adding 384 width device support
Adding tests for the mobile viewport
Adding pipeline to run on daily basis to test images on Production

Adding device sizes array for SIZE props.
https://nextjs.org/docs/pages/api-reference/components/image#devicesizes

Affected Route: `/` Fixed : #2362 Adding device sizes array for SIZE props. https://nextjs.org/docs/pages/api-reference/components/image#devicesizes

github-actions · 2024-03-25T02:49:02Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🔴	Statements	0.25%	69/27649
🔴	Branches	8.86%	24/271
🔴	Functions	1.2%	3/250
🔴	Lines	0.25%	69/27649

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from f0365f0

github-actions · 2024-03-25T03:01:33Z

Deployed changes to https://app-sswwebsite-9eb3-pr-2363.azurewebsites.net

github-actions · 2024-03-25T03:03:34Z

PageSpeed Insights

Category	Score
Accessibility	90
Best practices	96
Performance	49
SEO	93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2363.azurewebsites.net

github-actions · 2024-03-25T03:51:32Z

Deployed changes to https://app-sswwebsite-9eb3-pr-2363.azurewebsites.net

github-actions · 2024-03-25T03:52:20Z

PageSpeed Insights

Category	Score
Accessibility	90
Best practices	96
Performance	38
SEO	93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2363.azurewebsites.net

github-actions · 2024-03-25T04:29:40Z

Deployed changes to https://app-sswwebsite-9eb3-pr-2363.azurewebsites.net

github-actions · 2024-03-25T04:32:04Z

PageSpeed Insights

Category	Score
Accessibility	90
Best practices	96
Performance	44
SEO	93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2363.azurewebsites.net

github-actions · 2024-03-25T05:28:20Z

Deployed changes to https://app-sswwebsite-9eb3-pr-2363.azurewebsites.net

github-actions · 2024-03-25T05:29:12Z

PageSpeed Insights

Category	Score
Accessibility	90
Best practices	96
Performance	30
SEO	86

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2363.azurewebsites.net

github-actions · 2024-03-26T00:35:46Z

Deployed changes to https://app-sswwebsite-9eb3-pr-2363.azurewebsites.net

github-actions · 2024-03-26T00:36:29Z

PageSpeed Insights

Category	Score
Accessibility	90
Best practices	96
Performance	39
SEO	93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2363.azurewebsites.net

github-actions · 2024-03-26T01:20:35Z

Deployed changes to https://app-sswwebsite-9eb3-pr-2363.azurewebsites.net

github-actions · 2024-03-26T01:22:05Z

PageSpeed Insights

Category	Score
Accessibility	90
Best practices	96
Performance	37
SEO	93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2363.azurewebsites.net

github-actions · 2024-03-29T04:31:36Z

Deployed changes to https://app-sswwebsite-9eb3-pr-2363.azurewebsites.net

github-actions · 2024-03-29T04:32:50Z

PageSpeed Insights

Category	Score
Accessibility	96
Best practices	96
Performance	29
SEO	86

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2363.azurewebsites.net

github-actions · 2024-03-29T05:52:18Z

Deployed changes to https://app-sswwebsite-9eb3-pr-2363.azurewebsites.net

github-actions · 2024-03-29T05:53:06Z

PageSpeed Insights

Category	Score
Accessibility	90
Best practices	96
Performance	39
SEO	93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2363.azurewebsites.net

github-actions · 2024-04-02T00:48:03Z

Deployed changes to https://app-sswwebsite-9eb3-pr-2363.azurewebsites.net

github-actions · 2024-04-02T00:51:04Z

PageSpeed Insights

Category	Score
Accessibility	90
Best practices	96
Performance	34
SEO	93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2363.azurewebsites.net

wicksipedia

Let’s merge this
Can you add a pbi to review and improve

amankumarrr · 2024-04-02T01:30:39Z

Let’s merge this Can you add a pbi to review and improve

Done - here is the issue #2398

Fixing homepage broken image

004acf5

Affected Route: `/` Fixed : #2362 Adding device sizes array for SIZE props. https://nextjs.org/docs/pages/api-reference/components/image#devicesizes

Adding mobile browser for the Playwright

3ac1c5c

Adding browser for mobile safari

42c3b6f

amankumarrr requested a review from wicksipedia as a code owner March 25, 2024 04:15

Modifying tests for the mobile screen

71d537b

Running the template on pr trigger

77ce125

amankumarrr marked this pull request as draft March 25, 2024 23:31

amankumarrr added 3 commits March 26, 2024 10:31

Adding env for the template

d4494ca

Adding more attempts

77d8af4

Adding waituntil prop

4e33df7

amankumarrr added 3 commits March 26, 2024 11:59

Adding chromium browser for mobile viewport

eab2af1

Undo the changes in the template

888ad26

Changing attempts to 2 from 4

7f63a2f

amankumarrr marked this pull request as ready for review March 26, 2024 01:08

amankumarrr requested review from Harry-Ross and removed request for wicksipedia March 26, 2024 01:09

amankumarrr marked this pull request as draft March 26, 2024 01:42

amankumarrr added 5 commits March 29, 2024 15:06

Changing the condition

b7b728e

Adding true check for the job

b3d574c

removing double quote for true

934e772

adding output value for create issue

8bf2ea3

Adding new false for consistency

762a8cc

amankumarrr added 14 commits March 29, 2024 15:42

Adding extra condition

3b2dae5

Wrapping with the variable name

8be26b9

removing condition

48fa91d

Adding extra echo

58aac10

adding env for the github action

c94c025

removing echo

602d92a

adding quote to create issue variable

b73298c

removing continue on true

aa12eac

Adding variable for the continue on error

7f1fc32

failure condition for the job

0c4efd2

Removing redundant steps

ce270ae

Updating the variables and cleanup

82c4324

Removing error

a2a6231

removing pull request trigger

8edf96e

Adding step to checkout repo for the template

f0365f0

wicksipedia approved these changes Apr 2, 2024

View reviewed changes

amankumarrr merged commit b78bc53 into main Apr 2, 2024
12 checks passed

amankumarrr deleted the 2362-broken-images-homepage branch April 2, 2024 01:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing homepage broken image #2363

Fixing homepage broken image #2363

amankumarrr commented Mar 25, 2024 •

edited

github-actions bot commented Mar 25, 2024 •

edited

github-actions bot commented Mar 25, 2024

github-actions bot commented Mar 25, 2024

github-actions bot commented Mar 25, 2024

github-actions bot commented Mar 25, 2024

github-actions bot commented Mar 25, 2024

github-actions bot commented Mar 25, 2024

github-actions bot commented Mar 25, 2024

github-actions bot commented Mar 25, 2024

github-actions bot commented Mar 26, 2024

github-actions bot commented Mar 26, 2024

github-actions bot commented Mar 26, 2024

github-actions bot commented Mar 26, 2024

github-actions bot commented Mar 29, 2024

github-actions bot commented Mar 29, 2024

github-actions bot commented Mar 29, 2024

github-actions bot commented Mar 29, 2024

github-actions bot commented Apr 2, 2024

github-actions bot commented Apr 2, 2024

wicksipedia left a comment

amankumarrr commented Apr 2, 2024

Fixing homepage broken image #2363

Fixing homepage broken image #2363

Conversation

amankumarrr commented Mar 25, 2024 • edited

github-actions bot commented Mar 25, 2024 • edited

Coverage report

Test suite run success

github-actions bot commented Mar 25, 2024

github-actions bot commented Mar 25, 2024

PageSpeed Insights

github-actions bot commented Mar 25, 2024

github-actions bot commented Mar 25, 2024

PageSpeed Insights

github-actions bot commented Mar 25, 2024

github-actions bot commented Mar 25, 2024

PageSpeed Insights

github-actions bot commented Mar 25, 2024

github-actions bot commented Mar 25, 2024

PageSpeed Insights

github-actions bot commented Mar 26, 2024

github-actions bot commented Mar 26, 2024

PageSpeed Insights

github-actions bot commented Mar 26, 2024

github-actions bot commented Mar 26, 2024

PageSpeed Insights

github-actions bot commented Mar 29, 2024

github-actions bot commented Mar 29, 2024

PageSpeed Insights

github-actions bot commented Mar 29, 2024

github-actions bot commented Mar 29, 2024

PageSpeed Insights

github-actions bot commented Apr 2, 2024

github-actions bot commented Apr 2, 2024

PageSpeed Insights

wicksipedia left a comment

Choose a reason for hiding this comment

amankumarrr commented Apr 2, 2024

amankumarrr commented Mar 25, 2024 •

edited

github-actions bot commented Mar 25, 2024 •

edited