Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline - Adding acr img clean up #2222

Merged
merged 69 commits into from Mar 5, 2024
Merged

Pipeline - Adding acr img clean up #2222

merged 69 commits into from Mar 5, 2024

Conversation

amankumarrr
Copy link
Member

@amankumarrr amankumarrr commented Feb 29, 2024

Fixed #2210 and Fixed #1228

image

Figure: Remaining ACR tag count and manifest count

TODO: Once, PR is merged, manual non PR tags need to be deleted with newly created flow

image

Figure: Utilized space after clean up

Removed GITHUB.SHA tag from the build and push action to avoid the creation of orphaned Docker images every time a new GitHub SHA is generated.

extra-tag

Figure: Tag from the build and push step

Copy link

github-actions bot commented Feb 29, 2024

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 0.26% 69/26343
🔴 Branches 9.16% 24/262
🔴 Functions 1.24% 3/241
🔴 Lines 0.26% 69/26343

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 518ec5e

Copy link

Deployed changes to https://app-sswwebsite-9eb3-pr-2222.azurewebsites.net

Copy link

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 28.000000000000004
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2222.azurewebsites.net

Copy link

Deployed changes to https://app-sswwebsite-9eb3-pr-2222.azurewebsites.net

Copy link

Deployed changes to https://app-sswwebsite-9eb3-pr-2222.azurewebsites.net

Copy link

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 38
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2222.azurewebsites.net

Copy link

Deployed changes to https://app-sswwebsite-9eb3-pr-2222.azurewebsites.net

Copy link

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 45
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2222.azurewebsites.net

Copy link

Deployed changes to https://app-sswwebsite-9eb3-pr-2222.azurewebsites.net

Copy link

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 32
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2222.azurewebsites.net

Copy link

github-actions bot commented Mar 4, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-2222.azurewebsites.net

@amankumarrr amankumarrr marked this pull request as ready for review March 4, 2024 05:06
Copy link

github-actions bot commented Mar 4, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-2222.azurewebsites.net

Copy link

github-actions bot commented Mar 4, 2024

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 30
SEO 86

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2222.azurewebsites.net

Copy link

github-actions bot commented Mar 4, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-2222.azurewebsites.net

Copy link

github-actions bot commented Mar 5, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-2222.azurewebsites.net

Copy link

github-actions bot commented Mar 5, 2024

PageSpeed Insights

Category Score
Accessibility 42
Best practices 0
Performance 0
SEO 0

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2222.azurewebsites.net

Copy link

github-actions bot commented Mar 5, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-2222.azurewebsites.net

Copy link

github-actions bot commented Mar 5, 2024

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 28.999999999999996
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2222.azurewebsites.net

Copy link
Member

@wicksipedia wicksipedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with changes

Copy link

github-actions bot commented Mar 5, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-2222.azurewebsites.net

Copy link

github-actions bot commented Mar 5, 2024

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 28.000000000000004
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2222.azurewebsites.net

@amankumarrr amankumarrr merged commit 438aaf8 into main Mar 5, 2024
11 checks passed
@amankumarrr amankumarrr deleted the 2210-spendOps branch March 5, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpendOps - Clean up old images in ACR 💸 Tech Debt - Active prs and slots check
2 participants