Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📄 Content - Add Caption Fields #2213

Merged
merged 12 commits into from Mar 1, 2024
Merged

📄 Content - Add Caption Fields #2213

merged 12 commits into from Mar 1, 2024

Conversation

Harry-Ross
Copy link
Contributor

@Harry-Ross Harry-Ross commented Feb 28, 2024

image
Figure: Video caption on /consulting/react

image
Figure: Editing the video caption on /admin

Copy link

github-actions bot commented Feb 28, 2024

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 0.26% 69/26105
🔴 Branches 9.3% 24/258
🔴 Functions 1.27% 3/237
🔴 Lines 0.26% 69/26105

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 9ea434c

Copy link

Deployed changes to https://app-sswwebsite-9eb3-pr-2213.azurewebsites.net

Copy link

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 37
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2213.azurewebsites.net

Copy link
Member

@wicksipedia wicksipedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment but lgtm

Copy link

github-actions bot commented Mar 1, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-2213.azurewebsites.net

Copy link

github-actions bot commented Mar 1, 2024

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 28.000000000000004
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2213.azurewebsites.net

Copy link

github-actions bot commented Mar 1, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-2213.azurewebsites.net

Copy link

github-actions bot commented Mar 1, 2024

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 28.000000000000004
SEO 86

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2213.azurewebsites.net

@Harry-Ross Harry-Ross merged commit 89a9bcc into main Mar 1, 2024
11 checks passed
@Harry-Ross Harry-Ross deleted the 1620-title-duration branch March 1, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💸 Videos - should show title and duration as a figure
2 participants