Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements about Power BI source control and squash merging #8247

Merged
merged 4 commits into from Mar 25, 2024

Conversation

divgul
Copy link
Member

@divgul divgul commented Mar 24, 2024

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️Discussion with @wicksipedia related to email w/ subject: IMPORTANT⚠️ PowerBI - lost source code history

  1. What was changed?

✏️2 rules were updated.
Changes in rule on Power BI Source control:

  • Uploaded better image showing drawbacks of adding .pbix files to source control
  • 3 text changes:
    • Added section heading at the very top
    • Improved the caption for the image showing drawbacks of adding pbix files to source control
    • Moved sentence about converting pbix to PBIP in a better place so that the flow is better

Changes in rule on doing squash merge:

  • Uploaded a better image showing messiness caused by not using squash merge
  1. Did you do pair or mob programming (list names)?

✏️No but have got feedback from @wicksipedia

3 text changes:
- Added section heading at the very top
- Improved the caption for the image showing drawbacks of adding pbix files to source control
- Moved sentence about converting pbix to PBIP in a better place so that the flow is better
@divgul divgul enabled auto-merge (squash) March 24, 2024 23:56
@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Mar 25, 2024
Co-authored-by: Matt Wicks [SSW] <wicksipedia@users.noreply.github.com>
@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old and removed Age: 🥚 - New About 2 hours old labels Mar 25, 2024
Copy link
Member

@wicksipedia wicksipedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@divgul divgul merged commit 902f6cd into SSWConsulting:main Mar 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🐣 - Young About 4 hours old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants