XS✔ ◾ Typescript Enums Rule #8193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harry-Ross
requested review from
bradystroud,
wicksipedia,
tomek-i,
amankumarrr,
calumjs and
christoment
PR Metrics✔ Thanks for keeping your pull request small.
Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs! |
github-actions
bot
added
Age: 🐣 - Young
github-actions
bot
added
Age: 🦖 - Extinct
wicksipedia
reviewed
Mar 26, 2024
wicksipedia
reviewed
Mar 26, 2024
christoment
reviewed
Mar 26, 2024
There was a problem hiding this comment.
I think we need to dig a bit more on when to use enum in the code, and when to use const object.
My thoughts: collection of values in a const is not an enum - they are separate use cases and for different purpose 😄
Also see https://www.typescriptlang.org/docs/handbook/enums.html#objects-vs-enums and https://github.com/rbuckton/proposal-enum
wicksipedia
reviewed
Mar 26, 2024
wicksipedia
reviewed
Mar 26, 2024
wicksipedia
reviewed
Mar 26, 2024
wicksipedia
reviewed
Mar 26, 2024
wicksipedia
reviewed
Mar 26, 2024
wicksipedia
approved these changes
Mar 26, 2024
Formatted enum Co-authored-by: Matt Wicks [SSW] <wicksipedia@users.noreply.github.com>
Reworded phrasing Co-authored-by: Matt Wicks [SSW] <wicksipedia@users.noreply.github.com>
…ing/SSW.Rules.Content into typescript-enums-rule
…ing/SSW.Rules.Content into typescript-enums-rule
Harry-Ross
dismissed
bradystroud’s stale review
On leave in a different timezone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip: Use SSW Rule Writer GPT for help with writing rules 🤖
✏️ There have been some duplication issues with enums on the SSW.Website, thought its important for people to understand const assertions.
✏️ Added a new rule: Do you know the pitfalls of TypeScript enums?
✏️ No