Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Add Bicep User-defined Data Type Rule #8189

Merged
merged 9 commits into from Mar 28, 2024
Merged

Conversation

ricksu978
Copy link
Member

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

PBI from SSW EagleEye project

  1. What was changed?
  • Added new Category "Rules to better Infrastructure as Code (IaC)"
  • Added new Rule "Bicep - Do you use User-defined Data Types?"
  1. Did you do pair or mob programming (list names)?

No

Copy link
Contributor

Hi @ricksu978,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/bicep-do-you-use-user-defined-data-types/rule.md Line 20 MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: top-level headings in the same document Rule MD025
rules/bicep-do-you-use-user-defined-data-types/rule.md Line 24 MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: top-level headings in the same document Rule MD025

Please review and update your Markdown files accordingly.

Copy link
Contributor

github-actions bot commented Mar 19, 2024

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 60
Total 60

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Add Bicep User-defined Data Type Rule XS✔ ◾ Add Bicep User-defined Data Type Rule Mar 19, 2024
@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old labels Mar 19, 2024
@github-actions github-actions bot added Age: 🐓 - Old About 32 hours old Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old labels Mar 20, 2024
Copy link
Contributor

Howzit @ricksu978,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@github-actions github-actions bot added Age: 🦖 - Extinct About 128 hours old and removed Age: 🍗 - Ancient About 64 hours old labels Mar 22, 2024
Co-authored-by: Matt Wicks [SSW] <wicksipedia@users.noreply.github.com>
Copy link
Member

@wicksipedia wicksipedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ricksu978 ricksu978 merged commit f89af88 into main Mar 28, 2024
5 checks passed
@ricksu978 ricksu978 deleted the bicep-user-define-type branch March 28, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🦖 - Extinct About 128 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants