Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a failing concurrency test #480

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

roetlich
Copy link
Contributor

Add a test to AcceptanceTests.AppendStream that fails for postgres but passes for all other DBs. This is to reproduce a bug with concurrent appends in postgres, see: #478

@thefringeninja
Copy link
Member

@roetlich can you rebase your PR please?

@roetlich roetlich force-pushed the failing-concurrency-test-for-postgres branch from c5b0a26 to dc18132 Compare November 26, 2020 09:18
@stoft
Copy link

stoft commented Dec 18, 2020

@thefringeninja rebased.

@Mousaka
Copy link

Mousaka commented May 2, 2021

Me and @EddieChoCho tried to find a solution for this but has not succeeded yet. However, we found out that it's this exception causing this test to fail:
https://github.com/SQLStreamStore/SQLStreamStore/blob/master/src/SqlStreamStore.Postgres/PgSqlScripts/EnforceIdempotentAppend.sql#L34

@thefringeninja
Copy link
Member

Sorry for the late reply. Is this something that fails occasionally?

@thefringeninja thefringeninja self-assigned this Jul 20, 2021
@roetlich
Copy link
Contributor Author

When I made this PR, the test was failing consistently for me locally. AFAIR it also failed in the CI here in GitHub, but it was shown as a passing check by some mistake. But it's been a few month, but maybe with current code that's not the case anymore and I might be misremembering something.

@thefringeninja
Copy link
Member

Part of the problem is that I can't re-run the checks associated with the PR. I guess it's because you are not a committer? I'll take a closer look at this soon

@Mousaka
Copy link

Mousaka commented Jul 21, 2021

It was consistently failing for me locally as well when I was running it

@roetlich roetlich force-pushed the failing-concurrency-test-for-postgres branch from 2e4256e to dc18132 Compare July 21, 2021 12:43
Add a test to AcceptanceTests.AppendStream that fails for postgres but passes for all other DBs. This is to reproduce a bug with concurrent appends in postgres, see: SQLStreamStore#478

Co-authored-by: Rasmus Larsson <stoft@users.noreply.github.com>
@roetlich roetlich force-pushed the failing-concurrency-test-for-postgres branch from dc18132 to 82f9e0b Compare July 21, 2021 12:45
@roetlich
Copy link
Contributor Author

roetlich commented Jul 21, 2021

I rebased this on top of your master, so the CI was retriggered. Now it even shows which test is failing! 😁

@roetlich
Copy link
Contributor Author

@thefringeninja is there any update on this? Can I help you with testing this in any way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants