-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a failing concurrency test #480
base: master
Are you sure you want to change the base?
Add a failing concurrency test #480
Conversation
@roetlich can you rebase your PR please? |
c5b0a26
to
dc18132
Compare
@thefringeninja rebased. |
Me and @EddieChoCho tried to find a solution for this but has not succeeded yet. However, we found out that it's this exception causing this test to fail: |
Sorry for the late reply. Is this something that fails occasionally? |
When I made this PR, the test was failing consistently for me locally. AFAIR it also failed in the CI here in GitHub, but it was shown as a passing check by some mistake. But it's been a few month, but maybe with current code that's not the case anymore and I might be misremembering something. |
Part of the problem is that I can't re-run the checks associated with the PR. I guess it's because you are not a committer? I'll take a closer look at this soon |
It was consistently failing for me locally as well when I was running it |
2e4256e
to
dc18132
Compare
Add a test to AcceptanceTests.AppendStream that fails for postgres but passes for all other DBs. This is to reproduce a bug with concurrent appends in postgres, see: SQLStreamStore#478 Co-authored-by: Rasmus Larsson <stoft@users.noreply.github.com>
dc18132
to
82f9e0b
Compare
I rebased this on top of your master, so the CI was retriggered. Now it even shows which test is failing! 😁 |
@thefringeninja is there any update on this? Can I help you with testing this in any way? |
Add a test to AcceptanceTests.AppendStream that fails for postgres but passes for all other DBs. This is to reproduce a bug with concurrent appends in postgres, see: #478