Don't install SFML when installing the project #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eXpl0it3r
reviewed
Nov 13, 2023
eXpl0it3r
approved these changes
Nov 22, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a case of adding the subdirectory with
EXCLUDE_FROM_ALL. In cmake 3.28 you can pass this property directly to fetchcontent which is nicer but presume we're a way off using that versionAlso had to change the fetch content name to lowercase, which is required for the source/binary dir variables to work correctly and is good practice anyway.
closes #6
edit: bonus side-effect of users not having to build sfml modules they aren't using