Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing the target also installs SFML files #6

Closed
eXpl0it3r opened this issue Jul 5, 2022 · 4 comments · Fixed by #8 · May be fixed by #28
Closed

Installing the target also installs SFML files #6

eXpl0it3r opened this issue Jul 5, 2022 · 4 comments · Fixed by #8 · May be fixed by #28
Labels
bug Something isn't working

Comments

@eXpl0it3r
Copy link
Member

It's kind of a common problem with FetchContent that it also pulls in all the install instructions from the fetched content.
There some workarounds with manual add_subdirectory and EXCLUDE_FROM_ALL, not sure what's the best solution.

@eXpl0it3r eXpl0it3r added the bug Something isn't working label Jul 5, 2022
@ChrisThrasher
Copy link
Member

I've used that workaround before, in particular to avoid installing a testing framework. It works well in my experience.

In this case I think our best option is to simply remove that install command. If a user builds shared libraries, as SFML does by default, they do need to install SFML to use their executable since the assumption is that after installation, the repo used to build the project may get deleted without anything breaking. This template targets users who are likely not shipping programs so I think it's fair to omit any installation code.

@ChrisThrasher
Copy link
Member

What do you think about simply removing that install command? Installing programs with runtime assets is not trivial and is out of the scope of this template so I'd rather not encourage anyone do that.

@eXpl0it3r
Copy link
Member Author

eXpl0it3r commented Sep 1, 2022

Makes the template kind of useless for me personally, which would be a shame.

I don't want to scrap together the necessary files from the build directory, whenever I want to put together a clean build.

@ChrisThrasher
Copy link
Member

I don't want to scrap together the necessary files from the build directory, whenever I want to put together a clean build.

I'm not sure what this means.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants