Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rect Contains With Vector2 #191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rect Contains With Vector2 #191

wants to merge 1 commit into from

Conversation

Rosst0pher
Copy link
Contributor

Adds Contains overload with Vector2 position for FloatRect and IntRect structures

@Rosst0pher Rosst0pher marked this pull request as draft July 30, 2020 15:29
@Rosst0pher Rosst0pher marked this pull request as ready for review July 30, 2020 15:30
DemoXinMC
DemoXinMC suggested changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@DemoXinMC DemoXinMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vector2u also exists, and while not likely commonly used, for completeness sake, let's go ahead and add an overload for that as well.

@Rosst0pher
Copy link
Contributor Author

Added overloads for all Vector2 variants

@Rosst0pher Rosst0pher force-pushed the feature/convenient-overloads branch from 19f591f to c438ccc Compare July 30, 2020 16:15
@eXpl0it3r eXpl0it3r mentioned this pull request May 23, 2024
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DemoXinMC DemoXinMC DemoXinMC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rosst0pher @DemoXinMC