Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most Window module APIs require a display which means pulling in the same
xvfb
infrastructure SFML uses. We can do that eventually, but for now I wrote some quicksfJoystick
tests since these don't require a display to be ran in CI.This is yet another instance where having CSFML live inside SFML/SFML would be useful since it could easily pick up the existing infrastructure SFML has like this
xvfb
stuff or our clang-format and clang-tidy infrastructure. This is certainly out of scope for SFML 3 but it's still something I'm considering for the future since I think it's both feasible and beneficial.