Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock pandas sub-dependency and update pytz #4652

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

axelstudios
Copy link
Member

@axelstudios axelstudios commented Apr 29, 2024

Any background context you want to provide?

Several CI actions independently build the docker image, and pandas wheel compilation was adding ~35 minutes to the tasks

What's this PR do?

Locks pandas to v2.2.2 in the buildingid dependency
Updates pytz and python-dateutil to the latest versions for compatibility

CI performance improvement:
Before After
unittests (api) 44m 2s 13m 6s
unittests (django) 1h 37m 2s 1h 3m 22s
unittests (functional) 43m 55s 12m 28s

How should this be manually tested?

Check that all timezone and date functionality still work as expected

@axelstudios axelstudios added the Maintenance Tag as maintenance if the issue relates to general cleanup, maintenance, etc. Do not delete label. label Apr 29, 2024
@axelstudios
Copy link
Member Author

Don't merge until v3.0 is officially released

@nllong nllong changed the title Lock pandas sub-dependency Lock pandas sub-dependency and update pytz May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Maintenance Tag as maintenance if the issue relates to general cleanup, maintenance, etc. Do not delete label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants