Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email #4642

Merged
merged 12 commits into from May 10, 2024
Merged

Fix email #4642

merged 12 commits into from May 10, 2024

Conversation

haneslinger
Copy link
Contributor

[

Any background context you want to provide?

What's this PR do?

How should this be manually tested?

What are the relevant tickets?

Screenshots (if appropriate)](#4639)

Copy link

Label error. Requires at least 1 of: Feature, Bug, Enhancement, Maintenance, Documentation, Performance, Do not publish. Found:

@kflemin kflemin added the Bug label Apr 17, 2024
@axelstudios
Copy link
Member

axelstudios commented Apr 18, 2024

  • Don't downgrade package-lock.json

@nllong
Copy link
Member

nllong commented Apr 23, 2024

This seems close, but when I select only a single property, then no data are sent. If I select two items in the inventory, then the first is selected. It feels like we have an off by one issue.

To test, by default the emailer is your console. So if you had an email address to a property's owner_email field and add the following email template in the http://127.0.0.1:8000/app/#/accounts/10/email_templates config, then when you select and run, it will show up in your console.

Hello owner of {{ubid}}!

You have a square footage of {{gross_floor_area}}.

Enjoy!

@haneslinger
Copy link
Contributor Author

@nllong, I don't see the emails in my console, but I do see log that imply both selected properties were sent emails

seed_web       | [INFO]2024-04-23 09:38:45 PID 15: Process finished, 2 attempted, 2 sent, 0 failed, 0 requeued
seed_web       | 2024-04-23 09:38:45 INFO     Process finished, 2 attempted, 2 sent, 0 failed, 0 requeued
seed_web       | [INFO]2024-04-23 09:38:45 PID 15: 2 emails attempted, 2 sent, 0 failed, 0 requeued
seed_web       | 2024-04-23 09:38:45 INFO     2 emails attempted, 2 sent, 0 failed, 0 requeued

are you sure both of your selected properties have emails?

Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet after fixing the ID to property view, then all worked.

@nllong nllong merged commit 4100268 into develop May 10, 2024
9 checks passed
@nllong nllong deleted the 4639-fix-emails branch May 10, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants