Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null values in related columns #4626

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

axelstudios
Copy link
Member

What's this PR do?

Related values could be null, when we were expecting strings. This change fixes that issue

How should this be manually tested?

  1. Create a new database
  2. Import covered-buildings-sample.csv with taxlot and property mappings
  3. Check that the inventory list loads

What are the relevant tickets?

#4624

@axelstudios axelstudios force-pushed the bugfix/4624-handle-null-values branch 2 times, most recently from 8316808 to 0fcbdd7 Compare April 11, 2024 23:02
Copy link
Contributor

@kflemin kflemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩🤩🤩🤩

@axelstudios axelstudios force-pushed the bugfix/4624-handle-null-values branch from 0fcbdd7 to 8c60dc8 Compare April 11, 2024 23:07
@axelstudios axelstudios merged commit 52689c5 into develop Apr 11, 2024
8 of 9 checks passed
@axelstudios axelstudios deleted the bugfix/4624-handle-null-values branch April 11, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants