-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render scenario ui-grid on expand #4599
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perryr16
added
the
Enhancement
Add this label if functionality was generally improved but not a full feature or maintentance.
label
Mar 29, 2024
I used the following script to count the number of watchers on the page. Just paste this into the dev tools console, no break points, just console.
|
kflemin
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏆
axelstudios
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancement
Add this label if functionality was generally improved but not a full feature or maintentance.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
The Scenarios & Measures section of the inventory detail page features a table of scenarios that can be expanded to show a nested ui-grid of the associated measures. Properties with numerous scenarios/measures can experience long loading times as each scenario's ui-grid introduces watchers that can slow down angular's performance.
What's this PR do?
Below is some bench marking with a property that has 8 scenarios, 6 of which have 1-3 measures (10 measures total).
How should this be manually tested?
Load the property detail of a property with several scenarios/measures
What are the relevant tickets?
#4597
Screenshots (if appropriate)