Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect on org change if necessary #4576

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Conversation

perryr16
Copy link
Contributor

@perryr16 perryr16 commented Mar 19, 2024

Any background context you want to provide?

When changing the organization from the menu, the page did not redirect to that org's data if the url contained an organization_id argument.

What's this PR do?

checks for the presence of the organization_id arg and updates it if necessary

How should this be manually tested?

With multiple orgs navigate to any of the organization settings pages. Change the org from the dropdown. The page data should reflect the newly selected org.

What are the relevant tickets?

#4575

Screenshots (if appropriate)

Screenshot 2024-03-19 at 1 17 45 PM

Copy link

Label error. Requires at least 1 of: Feature, Bug, Enhancement, Maintenance, Documentation, Performance, Do not publish. Found:

@perryr16 perryr16 added the Bug label Mar 19, 2024
@perryr16 perryr16 requested a review from kflemin March 19, 2024 19:19
@perryr16 perryr16 marked this pull request as ready for review March 19, 2024 19:19
Copy link
Contributor

@kflemin kflemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this so much!! thank you! 🚚

@kflemin kflemin merged commit 12adec3 into develop Mar 20, 2024
8 checks passed
@kflemin kflemin deleted the 4575-bug-menu-org-change branch March 20, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants