-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ui5-shellbar): introducing assistant slot #8963
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnaydenow
requested changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all the generated css files from:
packages/fiori/test/pages/resources/css/
packages/main/test/pages/resources/css/
- deleted wrongly generated minified files
- restored wrongly deleted translation texts
- fixed build
- deleted unnecessary translation text and animation file
- deleted unwanted files
- fixed unit test
nnaydenow
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Тhe
showCoPilot
property and theco-pilot-click
event of theui5-shellbar
have been removed.In their place we now have a public slot called
assistant
. We recommend usingui5-toggle-button
withsap-icon://da
andsap-icon://da-2
icons (see the examples below).BREAKING CHANGE:
showCoPilot
property of theui5-shellbar
is removed.If you have previously used the
showCoPilot
property:it will no longer work for the component.
CoPilotAnimation
feature of theui5-shellbar
is removed.If you have previously used the
CoPilotAnimation
feature:it will no longer work for the component.
copilotDomRef
getter of theui5-shellbar
is removed.If you have previously used the
copilotDomRef
public getter:it will no longer work for the component.
co-pilot-click
event of theui5-shellbar
is removed.If you have previously used the
co-pilot-click
public event:it will no longer work for the component.
You can achieve similar functionality with the new slot:
HTML:
JavaScript:
Related to #8461, #7887