docs: update accessibility documentation #8938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenastoyanovaa
requested review from
ilhan007,
dobrinyonkov,
yanaminkova,
GerganaKremenska,
unazko and
simonarangelova
nnaydenow
reviewed
May 10, 2024
| @@ -198,127 +170,134 @@ Will result in the shadow DOM as: | |||
| ``` | |||
|
|
|||
| The `accessibilityAttributes` property is currently supported in: | |||
| * [Avatar](https://sap.github.io/ui5-webcomponents/nightly/components/Avatar/) | |||
There was a problem hiding this comment.
Not sure if it's correct to point nightly documentation.
There was a problem hiding this comment.
All links have been pointing to nightly since the creation of the documentation. Should I change all of them?
There was a problem hiding this comment.
Let's keep it this way for now, merge it and we will handle this late-on. In general it should not point to nightly and ideally be relative URL.
simonarangelova
approved these changes
May 10, 2024
unazko
reviewed
May 13, 2024
unazko
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8461