Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-multi-combobox): enable hierarchical groups #8928

Closed
wants to merge 7 commits into from

Conversation

ivoplashkov
Copy link
Member

@ivoplashkov ivoplashkov commented May 9, 2024

Removes the ui5-mcb-group-item component.

BREAKING CHANGE: The ui5-mcb-group-item component is removed. Groups can now be created with the ui5-mcb-group. Instead of using ui5-mcb-group-item as separator in a flat structure:

<ui5-multi-combobox placeholder="Select a country">
	<ui5-mcb-group-item text="Asia"></ui5-mcb-group-item>
        <ui5-mcb-item text="Afghanistan"></ui5-mcb-item>
        <ui5-mcb-item text="China"></ui5-mcb-item>
        <ui5-mcb-item text="India"></ui5-mcb-item>
        <ui5-mcb-item text="Indonesia"></ui5-mcb-item>
	<ui5-mcb-group-item text="Europe"></ui5-mcb-group-item>
        <ui5-mcb-item text="Austria"></ui5-mcb-item>
        <ui5-mcb-item text="Bulgaria"></ui5-mcb-item>
        <ui5-mcb-item text="Germany"></ui5-mcb-item>
        <ui5-mcb-item text="Italy"></ui5-mcb-item>
</ui5-multi-combobox>

The API supports nesting of ui5-mcb-item components inside an ui5-mcb-group:

<ui5-multi-combobox placeholder="Select a country">
	<ui5-mcb-group text="Asia">
		<ui5-mcb-item text="Afghanistan"></ui5-mcb-item>
		<ui5-mcb-item text="China"></ui5-mcb-item>
		<ui5-mcb-item text="India"></ui5-mcb-item>
		<ui5-mcb-item text="Indonesia"></ui5-mcb-item>
	</ui5-mcb-group>
	<ui5-mcb-group text="Europe">
		<ui5-mcb-item text="Austria"></ui5-mcb-item>
		<ui5-mcb-item text="Bulgaria"></ui5-mcb-item>
		<ui5-mcb-item text="Germany"></ui5-mcb-item>
		<ui5-mcb-item text="Italy"></ui5-mcb-item>
	</ui5-mcb-group>
</ui5-multi-combobox>

Relates to #8461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants