Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-button): add keyboard shortcut to cancel the button's action #8911

Merged
merged 3 commits into from
May 21, 2024
Merged

fix(ui5-button): add keyboard shortcut to cancel the button's action #8911

merged 3 commits into from
May 21, 2024
+26 −1

Conversation

unazko
Copy link
Contributor

@unazko unazko commented May 7, 2024

Fixes: #6782

hinzzx
hinzzx reviewed May 8, 2024
View reviewed changes
packages/main/src/Button.ts Outdated Show resolved Hide resolved
@unazko unazko requested a review from hinzzx May 8, 2024 14:33
@unazko unazko marked this pull request as ready for review May 20, 2024 13:00
@unazko unazko merged commit c2d9c85 into SAP:main May 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev vladitasev approved these changes

@hinzzx hinzzx hinzzx approved these changes

@tsanislavgatev tsanislavgatev Awaiting requested review from tsanislavgatev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button - Keyboard Interaction: “ESC” Key doesn’t work as expected (ACC)
3 participants
@unazko @vladitasev @hinzzx