Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button - Keyboard Interaction: “ESC” Key doesn’t work as expected (ACC) #6782

Closed
1 task done
blaesius opened this issue Mar 23, 2023 · 3 comments · Fixed by #8911
Closed
1 task done

Button - Keyboard Interaction: “ESC” Key doesn’t work as expected (ACC) #6782

blaesius opened this issue Mar 23, 2023 · 3 comments · Fixed by #8911
Assignees
@unazko
Labels
ACC bug This issue is a bug in the code Medium Prio TOPIC B
Projects
Maintenance - Topic B

Comments

@blaesius
Copy link

Bug Description

From ACC side it is described that the “ESC”-Key can be used to cancel triggering the action (in this case triggering the action) when using “ESC” while “SPACE” is pressed. This doesn’t work for the web component.

Affected Component

No response

Expected Behaviour

No response

Isolated Example

https://sap.github.io/ui5-webcomponents/playground/components/Button/

Steps to Reproduce

...

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.11.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@blaesius blaesius added the bug This issue is a bug in the code label Mar 23, 2023
@s-todorova s-todorova self-assigned this Mar 24, 2023
@s-todorova
Copy link
Contributor

Hello @blaesius,

Could you please provide a recording of how exactly you encouter this problem? I am unable to reproduce this issue on the playground page, which you've linked as an example.

Thank you in advance!

Best regards,
Siyana

@s-todorova s-todorova removed their assignment Mar 24, 2023
@blaesius
Copy link
Author

Hi Siyana,

yes, no problem.

Just navigate via keyboard using the tab until you reach a button. Press 'space' and hold it (to execute the button action via keyboard). If you now press ESC (while holding space), the action should be cancelled. We have this behavior already in UI5, you can check it there as well.

Kind regards,
Janina

@nnaydenow
Copy link
Contributor

Hi @SAP/ui5-webcomponents-topic-b,

Could you please check this? If click action is triggered by SPACE key user is not able to discard it by pressing SHIFT / ESCAPE key.

@nnaydenow nnaydenow added this to New Issues in Maintenance - Topic B via automation Mar 27, 2023
@unazko unazko self-assigned this Apr 19, 2023
@unazko unazko moved this from New Issues to In Progress in Maintenance - Topic B Apr 19, 2023
@unazko unazko mentioned this issue May 7, 2024
Merged
unazko added a commit that referenced this issue May 21, 2024
@unazko
fix(ui5-button): add keyboard shortcut to cancel the button's action
c2d9c85 
Fixes #6782
Maintenance - Topic B automation moved this from In Progress to Completed May 21, 2024
unazko added a commit to unazko/ui5-webcomponents that referenced this issue May 21, 2024
@unazko
fix(ui5-button): add keyboard shortcut to cancel the button's action
6ea2d21 
Fixes SAP#6782
@unazko unazko mentioned this issue May 21, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unazko unazko

Labels
ACC bug This issue is a bug in the code Medium Prio TOPIC B
Projects
Maintenance - Topic B
  
Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-button): add keyboard shortcut to cancel the button's action unazko/ui5-webcomponents
4 participants
@blaesius @unazko @nnaydenow @s-todorova