Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mitigate the PartitionMigratingException #313

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

halber
Copy link
Contributor

@halber halber commented May 11, 2023

When a node leaves or joins the cluster hazelcast will rebalance the cluster. If we unregister or register Entity verticles when the hazelcast cluster is not in a safe state we get
PartitionMigratingException's. This commit attempts to postpone the registration and unregistration until the cluster is in a safe state.

@halber halber requested a review from a team as a code owner May 11, 2023 07:38
@halber halber force-pushed the fix/clustering branch 3 times, most recently from 4fd4c55 to 87c90cb Compare May 11, 2023 11:04
@sonarcloud
Copy link

sonarcloud bot commented May 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@halber halber force-pushed the fix/clustering branch 2 times, most recently from 2a7f900 to e67a1b5 Compare June 19, 2023 13:01
When a node leaves or joins the cluster hazelcast will rebalance the
cluster. If we unregister or register Entity verticles when the
hazelcast cluster is not in a safe state we get
PartitionMigratingException's. This commit attempts to postpone the
registration and unregistration until the cluster is in a safe state.
@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: un-/registering entity verticles in hazelcast cluster when not in safe state
1 participant