Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): update Card to latest design #11730

Merged
merged 4 commits into from
May 15, 2024
Merged

Conversation

InnaAtanasova
Copy link
Contributor

@InnaAtanasova InnaAtanasova commented Apr 11, 2024

MORE UPDATES FROM STYLES WILL FOLLOW

Related Issue(s)

closes #11599

Description

The current PR

  • adds main, extended and numeric sections to Card header (this is a Breaking change)
  • refactored Card elements to use signals
  • added interactive cards
  • added Media cards
  • updated the documentation examples with the breaking changes
  • NOTE: missing unit tests

BREAKING CHANGE:

  • badge can now accept an icon and a color (badgeColor and badgeColorSecondary). Can also set aria-label attribute (badgeAriaLabel)
  • card by default is non-interactive. Can be set to interactive with interactive property set to true
  • interactive Cards must be with role listitem and inside a list fd-card-list
  • the Card header (main header) by default is not interactive, can be set to interactive with interactive property set to true. For example: <fd-card-main-header [interactive]="true">
  • the elements of the Card header now need to be wrapped in <fd-card-main-header> container

Before:

<fd-card-header>
    <h2 fd-card-title>Card Title</h2>
</fd-card-header>

After:

<fd-card-header>
    <fd-card-main-header>
        <h2 fd-card-title>Card Title</h2>
    </fd-card-main-header>
</fd-card-header>

@InnaAtanasova InnaAtanasova added this to the Sprint 133 - April 2024 milestone Apr 11, 2024
@InnaAtanasova InnaAtanasova requested a review from a team April 11, 2024 16:22
@InnaAtanasova InnaAtanasova self-assigned this Apr 11, 2024
Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 8c1ebe5
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/6643c9b0bac73a0008729c4b
😎 Deploy Preview https://deploy-preview-11730--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 11, 2024

Visit the preview URL for this PR (updated for commit 8c1ebe5):

https://fundamental-ngx-gh--pr11730-feat-card-header-new-iq7js2l0.web.app

(expires Fri, 17 May 2024 20:31:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@InnaAtanasova InnaAtanasova force-pushed the feat/card-header-new branch 9 times, most recently from 1cac8e3 to 0da19f5 Compare April 17, 2024 17:34
@InnaAtanasova InnaAtanasova changed the title feat(core): update Card header to latest design [WIP]feat(core): update Card header to latest design Apr 19, 2024
@InnaAtanasova InnaAtanasova force-pushed the feat/card-header-new branch 3 times, most recently from f935cb7 to 24f120d Compare May 14, 2024 18:06
@InnaAtanasova InnaAtanasova changed the title [WIP]feat(core): update Card header to latest design feat(core): update Card header to latest design May 14, 2024
@InnaAtanasova InnaAtanasova force-pushed the feat/card-header-new branch 4 times, most recently from c9cc64c to 6f771d4 Compare May 14, 2024 19:29
@InnaAtanasova InnaAtanasova changed the title feat(core): update Card header to latest design feat(core): update Card to latest design May 14, 2024
@InnaAtanasova InnaAtanasova merged commit b733c62 into main May 15, 2024
19 checks passed
@InnaAtanasova InnaAtanasova deleted the feat/card-header-new branch May 15, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Card header new design updates
3 participants