Remove use of closure. #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This encourages more people to handle buffer size changes.
Be-ing
reviewed
Dec 25, 2021
| /// | ||
| /// struct MyHandler {}; | ||
| /// impl jack::ProcessHandler for MyHandler { | ||
| /// fn buffer_size(&mut self, _: &jack::Client, _: jack::Frames) -> jack::Control { |
There was a problem hiding this comment.
Suggested change
| /// fn buffer_size(&mut self, _: &jack::Client, _: jack::Frames) -> jack::Control { | |
| /// fn buffer_size(&mut self, _: &jack::Client, _: jack::Frames) -> jack::Control { | |
| /// // resize data structures within your application |
Be-ing
reviewed
Dec 25, 2021
| @@ -19,6 +19,9 @@ lazy_static! { | |||
|
|
|||
| /// Defines the configuration for a certain port to JACK, ie 32 bit floating audio input, 8 bit raw | |||
| /// midi output, etc... | |||
| /// | |||
| /// # Safety | |||
| /// JACK types are dynamically sized so its more difficult to get right. | |||
|
I like this change to simplify the API. I think it's good to have exactly one right way to do a task so users don't have to wonder which is the right one for them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This encourages more people to handle buffer size changes.