Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added couchbase probe. #506

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jakewarr8
Copy link

#494

I created a new PR with a cleaner commit history.

@jakewarr8
Copy link
Author

@sjanuary Hi. I reopened a new PR with a cleaner commit log and the changes you wanted. Thanks for the help. Let me know if anything else needs changed.

@codecov-io
Copy link

codecov-io commented Nov 22, 2017

Codecov Report

Merging #506 into master will decrease coverage by 0.35%.
The diff coverage is 29.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #506      +/-   ##
==========================================
- Coverage    60.8%   60.45%   -0.36%     
==========================================
  Files          49       50       +1     
  Lines        3215     3252      +37     
==========================================
+ Hits         1955     1966      +11     
- Misses       1260     1286      +26
Impacted Files Coverage Δ
probes/couchbase-probe.js 29.72% <29.72%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d702f6e...9417b03. Read the comment docs.

@sjanuary
Copy link
Contributor

This is looking good to me, we just need to find the time to try it out ourselves, but we do aim to get this merged (might be after Christmas)

@blackrez
Copy link

Hello,

Any news from this merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants