Added 'month' parameter support for intraday data endpoints #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@masonJamesWheeler, hello! Thank you for the PR. I was considering creating my own, but I noticed that you have already created one. By the way, I took a look at your commit and discovered that it includes a broken file rename, resulting in a broken git history. Could you please revise your commit to fix this issue? I'm concerned that the maintainers might not merge the PR if the history remains broken. Moreover, TIME_SERIES_INTRADAY_EXTENDED function is depreciated, so |
|
Thankyou! Working on it now.
From: Aleksei Semenov ***@***.***>
Date: Sunday, July 16, 2023 at 12:40 PM
To: RomelTorres/alpha_vantage ***@***.***>
Cc: Mason J. Wheeler ***@***.***>, Mention ***@***.***>
Subject: Re: [RomelTorres/alpha_vantage] Added 'month' parameter support for intraday data endpoints (PR #348)
@masonJamesWheeler<https://urldefense.com/v3/__https:/github.com/masonJamesWheeler__;!!K-Hz7m0Vt54!kwe9uV_KvMA7FkOl6VwhBpnymvCiqIbgOI1EQcO2q_xKRshL8S8S_FAZEL_70SmEXRIwVxkhE42MR-EW74CgZA$>, hello! Thank you for the PR. I was considering creating my own, but I noticed that you have already created one.
By the way, I took a look at your commit and discovered that it includes a broken file rename, resulting in a broken git history. Could you please revise your commit to fix this issue? I'm concerned that the maintainers might not merge the PR if the history remains broken.
Moreover, TIME_SERIES_INTRADAY_EXTENDED function is depreciated, so TimeSeries.get_intraday_extended() method should be removed or marked as depreciated.
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/RomelTorres/alpha_vantage/pull/348*issuecomment-1637173527__;Iw!!K-Hz7m0Vt54!kwe9uV_KvMA7FkOl6VwhBpnymvCiqIbgOI1EQcO2q_xKRshL8S8S_FAZEL_70SmEXRIwVxkhE42MR-FHAkWqPg$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AZPGMIFG3RA26TGUZSXIMMLXQQ7RPANCNFSM6AAAAAA2JW2ICQ__;!!K-Hz7m0Vt54!kwe9uV_KvMA7FkOl6VwhBpnymvCiqIbgOI1EQcO2q_xKRshL8S8S_FAZEL_70SmEXRIwVxkhE42MR-HgNULhOQ$>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@masonJamesWheeler Thanks for this! I would love to see this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alpha Vantage recently discontinued their
intraday_extendedand introduced a 'month' parameter to their time-series and indicator data endpoints. This pull request updates the Python wrapper accordingly.Changes include:
This update should align the wrapper with the latest changes in Alpha Vantage's API and improve the overall user experience.