[Das_Schwarze_Auge_4-1] Regeneration Updates, Consideration of Spell Representations #12892

kreuvf · 2024-05-12T19:28:54Z

Submission Checklist

Required

The pull request title clearly contains the name of the sheet I am editing.
The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
The pull request makes changes to files in only one sub-folder.
The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description

Rollable Regeneration

Make regeneration clearer/prettier (048545b, 69d8c8f, 221b7ba, b539fae, 4bb350a, adc8344, 017eee1, db2033b)
Activation of regeneration tab no longer activates General tab first (649c8bf)
Changes to stats did not propagate to masterly regeneration bonus (7bf7914)
Add function generateAEBaseMasterlyRegenerationRoll() (d104743, 54b1af9)
Revise initialization/migration to catch cases leading to quirky astral energy regeneration (4da3b96)

Consideration of Spell Representations

This feature automatically applies any beneficial substitutions of stats in spell checks. Thanks to @Triqueon for laying the groundwork for this.

Add elven representation (1d8a6b4, 44cccb2, e75376e, 5844855)
Add crystallomantic representation (44cccb2)
Add kophtan representation (5ac2cdb, 5844855)
Add representation to each spell (388c642)
Communicate substitutions to the user (ca4e01f)
Use datalist for representations (b4c76f9)
Miscellaneous fixes (65000b9, 4ffb63d)

Other

Fixes

Passing blow (old button) selection "Aufmerksamkeit, aber kein Kampfgespür" does not apply the modifier and does not show the full text due to erroneous escaping (a54f93a)
Restore broken attribute names (e0d8bb9)

Interface/Style

Principal stat selection moved from special skill "Masterly Regeneration" to (more fitting) location next to representations (7c6b112)
Specialization buttons text size now matches text size of other roll buttons (4ebe036)

Miscellaneous

Add new constant arrays with frequently required data (23edb6b)
New utility function countStats() (ffa05e1)
Migration function (5ac2cdb)
Info on latest version (ab42a0c)
Regenerate sheet files (fd20e68)

…n an array of stats

Attribute renamed: z_erstrepraesentation -> sf_representations

Theoretically, any number of new representations with comparable rules could be implemented with ease now.

…rer to the user

* Closes #32 The third stat is a reference to the user-selected stat and as such is not counted correctly with countStats() if not resolved beforehand. This could lead to the incorrect replacement of "KL" with "CH" when using Kophtanic representation leading to CH/CH/CH stats (expressly forbidden).

* Closes #144

…es and units

…ain)

Connected with achieving this goal: * Make base rolls for LE/AE with fixed regeneration rolls of d1 to allow access for CRP * Fix: AEneu is not defined when fixed AE regeneration is enabled

…20) d20 rolls; base rolls with explanations)

This has been broken since 4d46c53 (2017-02-18!).

…E regeneration Suspected root causes: * Energies (LE, AE, AU, but KE was!) were not initialized * Food restriction effect attribute not set to the numeric value 0 failing a strict equality check

… Kampfgespür" does not apply the modifier and does not show the full text * Closes #135 Reason: The text contains a comma which was already saved in escaped form (,). The & had to be escaped as well.

… tab

…n attributes

roll20deploy · 2024-05-12T19:28:58Z

Character Sheet Info Roll20 Internal Use only.

Pascal Stein and others added 30 commits May 9, 2024 14:40

First attempt at elven rep special rules

1d8a6b4

Add reps for each spell

388c642

* Add utility function "countStats()" to count occurrences of stats i…

ffa05e1

…n an array of stats

Working implementation of Elf and Ach reps

44cccb2

Fix migration & Add kophtan rules

5ac2cdb

Made spellrep calculations more explicit

65000b9

* Representations: Use datalist(s) for flexibility and easy searching

b4c76f9

Attribute renamed: z_erstrepraesentation -> sf_representations

* Make elvish representation replacement more generic

e75376e

* Unify handling of Elvish and Kophtanic representations

5844855

Theoretically, any number of new representations with comparable rules could be implemented with ease now.

* Make spell check stat replacements due to spell representation clea…

ca4e01f

…rer to the user

* Fix: Activation of regeneration tab activates General tab

649c8bf

* Closes #144

* Regeneration: Move display of old and new value to header line

048545b

* Regeneration: Highlight header lines

69d8c8f

* Regeneration: Indent regeneration details

221b7ba

* Regeneration: Add no-breaking spaces to prevent breaks between valu…

b539fae

…es and units

* Regeneration: Right align regeneration effects

4bb350a

* Regeneration: Unify effect sign (negative = reduction, positive = g…

adc8344

…ain)

* Regeneration: Pretty-print all regeneration results with signs

017eee1

Connected with achieving this goal: * Make base rolls for LE/AE with fixed regeneration rolls of d1 to allow access for CRP * Fix: AEneu is not defined when fixed AE regeneration is enabled

* Regeneration: Enhance clearness of rolls (correctly coloured (cs1cf…

db2033b

…20) d20 rolls; base rolls with explanations)

* Fix: Repair broken attribute names for miracle+/- talents

e0d8bb9

This has been broken since 4d46c53 (2017-02-18!).

* Fix: Initialization/Migration for regeneration may lead to quirky A…

4da3b96

…E regeneration Suspected root causes: * Energies (LE, AE, AU, but KE was!) were not initialized * Food restriction effect attribute not set to the numeric value 0 failing a strict equality check

* Fix: Passing blow (old button) selection "Aufmerksamkeit, aber kein…

a54f93a

… Kampfgespür" does not apply the modifier and does not show the full text * Closes #135 Reason: The text contains a comma which was already saved in escaped form (,). The & had to be escaped as well.

* Fix specialization buttons' text size

4ebe036

* Fix: Changes to stats do not update masterly regeneration bonus

7bf7914

* Move principal stat selection from special skills tab to main spell…

7c6b112

… tab

* Add reusable arrays for stats attributes and for astral regeneratio…

23edb6b

…n attributes

* Add function generateAEBaseMasterlyRegenerationRoll()

d104743

* Use newly added function

54b1af9

* Add info on latest version

ab42a0c

* Regenerate sheet files

fd20e68

kreuvf marked this pull request as draft May 13, 2024 17:53

kreuvf marked this pull request as ready for review May 13, 2024 17:57

NBrooks-Roll20 merged commit 6666618 into Roll20:master May 14, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Das_Schwarze_Auge_4-1] Regeneration Updates, Consideration of Spell Representations #12892

[Das_Schwarze_Auge_4-1] Regeneration Updates, Consideration of Spell Representations #12892

kreuvf commented May 12, 2024 •

edited

roll20deploy commented May 12, 2024

[Das_Schwarze_Auge_4-1] Regeneration Updates, Consideration of Spell Representations #12892

[Das_Schwarze_Auge_4-1] Regeneration Updates, Consideration of Spell Representations #12892

Conversation

kreuvf commented May 12, 2024 • edited

Submission Checklist

Required

Changes / Description

Rollable Regeneration

Consideration of Spell Representations

Other

Fixes

Interface/Style

Miscellaneous

roll20deploy commented May 12, 2024

kreuvf commented May 12, 2024 •

edited