Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official Savage Worlds: fixes swade archetypes not dropping on vtt #12867

Merged
merged 3 commits into from May 14, 2024

Conversation

Kurohyou
Copy link
Contributor

@Kurohyou Kurohyou commented May 7, 2024

Submission Checklist

Required

  • The pull request title clearly contains the name of the sheet I am editing.
  • The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
  • The pull request makes changes to files in only one sub-folder.
  • The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

  • The name of this game is: < > (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

  • The publisher of this game is: < > (i.e. Wizards of the Coast, Evil Hat)

  • The name of this game system/family is: < > (i.e. Dungeons & Dragons, FATE)

  • I have followed the Character Sheets Standards when building this sheet.

  • I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.
  • This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: < >
  • This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Bug Fixes

  • Adds the correct class to the compendium drop target so that SWADE Archetypes can be dropped directly to VTT.

@Kurohyou Kurohyou requested a review from a team as a code owner May 7, 2024 17:28
@roll20deploy
Copy link
Contributor

Character Sheet Info Roll20 Internal Use only.

@Kurohyou Kurohyou changed the title fixes swade archetypes not dropping on vtt Official Savage Worlds: fixes swade archetypes not dropping on vtt May 7, 2024
@NBrooks-Roll20
Copy link
Contributor

Hi @Kurohyou! We noticed that, in addition to the fix you did, the 1.00.30 release notes and versioning was removed from the sheet. Was this intentional? If so, we'll just merge it, but we wanted to give you the opportunity to fix that if it wasn't intentional to roll the sheet back a version.

@Kurohyou
Copy link
Contributor Author

Kurohyou commented May 9, 2024

Hmm, there definitely shouldn't be any features removed. I'll double check that we didn't miss a merge on our git somewhere.

@Kurohyou
Copy link
Contributor Author

Kurohyou commented May 9, 2024

@NBrooks-Roll20, should be good for merge. The css file is still saying that there are changes, but all the "changes" are identical between the two versions. Guessing it's some issue with spaces vs. tabs or something.

@NorWhal NorWhal merged commit 64187d3 into Roll20:master May 14, 2024
1 check passed
@NorWhal NorWhal removed the blocked label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants